me/gin-gonic-prepack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce time taken by rate limit tests from a 1sec bucket to a 10ms bucket granularity

Browse Source
This commit is contained in:
🐙PiperYxzzy
2022-08-06 20:07:30 +02:00
parent 74538d6f23
commit cb40ac8cd1
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
controllers/ratelimit_test.go
View File

@@ -9,10 +9,10 @@ func TestBucketBehaviour(t *testing.T) {
b := bucket{ b := bucket{
rules: &map[string]rule{ rules: &map[string]rule{
"": {time.Second, 0}, // Deny "": {time.Second, 0}, // Deny
"/1sec5max": {time.Second, 5}, "/1sec5max": {time.Millisecond * 10, 5},
"/2sec1max": {time.Second * 2, 1}, "/2sec1max": {time.Millisecond * 20, 1},
"/wildcard/.+/1sec1max": {time.Second, 1}, "/wildcard/.+/1sec1max": {time.Millisecond * 10, 1},
"/regex/(test|woot)/1sec2max/[A-Z]{2,3}": {time.Second, 2}, "/regex/(test|woot)/1sec2max/[A-Z]{2,3}": {time.Millisecond * 10, 2},
}, },
access: map[string]int{}, access: map[string]int{},
} }
@@ -68,7 +68,7 @@ func TestBucketBehaviour(t *testing.T) {
} }
// Wait for the smallest duration, 1 second, and test // Wait for the smallest duration, 1 second, and test
time.Sleep(time.Second + time.Millisecond*200) time.Sleep(time.Millisecond * 12)
fourthTestShouldSucceedAgain := []string{ fourthTestShouldSucceedAgain := []string{
"/1sec5max", "/1sec5max",
@@ -97,7 +97,7 @@ func TestBucketBehaviour(t *testing.T) {
} }
} }
time.Sleep(time.Second + time.Millisecond*200) time.Sleep(time.Millisecond * 12)
fifthTestShouldNowSucceed := fourthTestShouldStillFail fifthTestShouldNowSucceed := fourthTestShouldStillFail
@@ -113,8 +113,8 @@ func TestMegabucketBehaviour(t *testing.T) {
m := megabucket{ m := megabucket{
rules: map[string]rule{ rules: map[string]rule{
"": {time.Second, 0}, // Deny "": {time.Second, 0}, // Deny
"/1sec5max": {time.Second, 5}, "/1sec5max": {time.Millisecond * 10, 5},
"/2sec1max": {time.Second * 2, 1}, "/2sec1max": {time.Millisecond * 20, 1},
}, },
buckets: map[string]bucket{}, buckets: map[string]bucket{},
} }
@@ -152,7 +152,7 @@ func TestMegabucketBehaviour(t *testing.T) {
} }
// Wait one second, confirm that both can do 5x 1sec5max again // Wait one second, confirm that both can do 5x 1sec5max again
time.Sleep(time.Second + time.Millisecond*200) time.Sleep(time.Millisecond * 12)
thirdTestUnblockedBothSucceed := []string{ thirdTestUnblockedBothSucceed := []string{
"/1sec5max", "/1sec5max",
@@ -170,4 +170,12 @@ func TestMegabucketBehaviour(t *testing.T) {
} }
} }
if m.take("user1", "/2sec1max") {
t.Errorf("user1 could take /2sec1max but should still be blocked")
}
if m.take("user2", "/2sec1max") {
t.Errorf("user2 could take /2sec1max but should still be blocked")
}
} }